Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable colour to fix CI #190

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Disable colour to fix CI #190

merged 1 commit into from
Jan 23, 2024

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Jan 23, 2024

The CI started failing like this:

image

Because the FORCE_COLOR=1 from the workflow is being passed to the tests, and adding colour to the output.

Let's instead disable colour for the affected tests by setting NO_COLOR to True, like we do with another, because colour isn't relevant to these tests.

@hugovk hugovk added testing Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46f649c) 98.97% compared to head (60c1d0b) 98.98%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   98.97%   98.98%           
=======================================
  Files           7        7           
  Lines         391      393    +2     
=======================================
+ Hits          387      389    +2     
  Misses          4        4           
Flag Coverage Δ
macos-latest 98.98% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 98.98% <100.00%> (+<0.01%) ⬆️
windows-latest 98.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk hugovk merged commit 27da2ae into main Jan 23, 2024
58 checks passed
@hugovk hugovk deleted the fix-ci branch January 23, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant