[Refactor] Use PHPMailer #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faishal Saiyed <[email protected]>
|
@faishal I think this is very cool! I'm really torn on whether to go for this refactor or not. It seems a lot more elegant and simpler that what we have now. @rmccue third opinion on taking this approach? I'm particularly sensitive to not breaking anything. I wonder if we could have an integration test of some sort to make sure there's no regressions here too. |
|
Don't know how it compares, but in case it got unnoticed: @diegoh's (MIT-licenced) https://github.com/creativecity/wp-aws-ses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp_mailpluggable method, hook into wp_mail & PHPmailer