Add missing hooks #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehoyle
reviewed
Nov 1, 2023
| // Compact the input and apply the filters | ||
| $atts = apply_filters( 'wp_mail', compact( 'to', 'subject', 'message', 'headers', 'attachments' ) ); | ||
|
|
||
| $pre_wp_mail = apply_filters( 'pre_wp_mail', null, $atts ); |
There was a problem hiding this comment.
Does core fire the pre_ hook after the wp_mail hook? Seems maybe the wrong way around
There was a problem hiding this comment.
This is still subject to testing to confirm everything is correct, but yes it does: https://github.com/WordPress/wordpress-develop/blob/f58f64587b221f5fade3b8d0a4163a08eb041ed9/src/wp-includes/pluggable.php#L177-L214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54 by adding missing filters and actions that have been added to the core
wp_mail()pluggable function since this package was originally built.The minimum PHP version bump is so we can use
list()with keys instead ofextract().Refs:
wp_mailandpre_wp_mail: https://github.com/WordPress/wordpress-develop/blob/a4a4f3a1dc68d84e2f3d24c8c9951ae962c6860d/src/wp-includes/pluggable.php#L175-L214wp_mail_failed: https://github.com/WordPress/wordpress-develop/blob/a4a4f3a1dc68d84e2f3d24c8c9951ae962c6860d/src/wp-includes/pluggable.php#L573-L581wp_mail_succeeded: https://github.com/WordPress/wordpress-develop/blob/a4a4f3a1dc68d84e2f3d24c8c9951ae962c6860d/src/wp-includes/pluggable.php#L548-L567