2.x.x - Add AsyncHTTPClient testing setup #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
changed the title
|
Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2023-12-21T13:51:16+00:00 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #317 +/- ##
==========================================
- Coverage 84.48% 83.26% -1.23%
==========================================
Files 82 84 +2
Lines 4532 4703 +171
==========================================
+ Hits 3829 3916 +87
- Misses 703 787 +84 ☔ View full report in Codecov by Sentry. |
Joannis
approved these changes
Dec 21, 2023
| @@ -76,7 +43,7 @@ final class HBXCTLive<App: HBApplicationProtocol>: HBXCTApplication { | |||
| } | |||
|
|
|||
| init(app: App) { | |||
| self.timeout = .seconds(15) | |||
| self.timeout = .seconds(20) | |||
There was a problem hiding this comment.
Any particular reason for this change?
There was a problem hiding this comment.
I had a test that had an AWS request in it which was timing out. I never got the AWS timeout because the client timed out. I should probably make this configurable.
Also merge HummingbirdCoreXCT with HummingbirdXCT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some testing requires a more fully featured HTTP client. This PR adds a testing framework that uses AsyncHTTPClient
This PR also merges HummingbirdCoreXCT into HummingbirdXCT
This PR includes #315 so it is probably best to review that first.