Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support system light/dark mode #377

Open
wetfloo opened this issue Jan 4, 2025 · 2 comments · May be fixed by #380
Open

Support system light/dark mode #377

wetfloo opened this issue Jan 4, 2025 · 2 comments · May be fixed by #380

Comments

@wetfloo
Copy link

wetfloo commented Jan 4, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • It seems like there no way to make hyfetch respect system light/dark theme
  • It also seems that there's no way to configure light/dark mode through cli args

Describe the solution you'd like

  • Add a cli flag to allow users to change a theme
  • Add an option that would make the fetch read system confguration

Describe alternatives you've considered
uhhh, color lightness ig, but that looks scuffed as hell

Additional context

I can take a look at this with a pull request if you want this feature. I have an idea of how to read system properties on both mac and linux, for windows I'll have to take a look. Also it'd be a good idea to implement fallback colors if the system theme isn't available
@wetfloo
Copy link
Author

wetfloo commented Jan 5, 2025 •
edited
Loading

Upon digging into this, it seems like the terminal color wasn't detected correctly, because I've messed up my tmux config (always detecting bg as 0, 0, 0)

Even when setting up the terminal variable properly (for example, so that $TERM would be xterm-kitty), it's not working correctly when switching the os theme, still responding with an old background (when tmux was started)

@wetfloo
Copy link
Author

wetfloo commented Jan 10, 2025

I investigated a bit and it seems that the issue is two-fold

  1. Because I'm using tmux, it thinks that the background color doesn't change until I kill the terminal that is currently attached and then reattach to the server
  2. The program itself chooses not to detect terminal color when it's run. Rather, it stores one term color mode in a json file

@wetfloo wetfloo linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto detect light/dark mode, changing the theme accordingly wetfloo/hyfetch
1 participant
@wetfloo