Auto detect light/dark mode, changing the theme accordingly #380
+51
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhhh changes are good but please don't reformat the codebase 😭 |
Comment on lines
+39
to
+44
| impl Default for TerminalTheme { | ||
| fn default() -> Self { | ||
| Self::Light | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think dark terminals are more popular so maybe setting this default to dark would be better?
sorry cargo fmt just kinda does that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability to detect terminal colors when
hyfetchis invoked, thereby adapting its themeRelevant Links
This partially resolves my issue
Screenshots
Screen.Recording.2025-01-10.at.23.06.14.mov
My new config
{ "preset": "transgender", "mode": "rgb", "auto_detect_light_dark": true, "lightness": 0.65, "color_align": { "mode": "horizontal" }, "backend": "fastfetch", "args": null, "distro": null, "pride_month_disable": false }If I have to write this in python, I'll scream (and then figure it out anyway)