Use flask app.extensions for storing registry #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #71 and #72, move registry from
app.config
toapp.extensions
Flask provides
app.extensions
as a specific place for extensions to store state, and many flask extensions do that (e.g. Flask-SQLAlchemy). This seems like the right place to storesvcs
state.app.config
is usually filled with things which might be set from an externalconfig.py
file, environment variable, or some other source. I often even like to be able to render these things back to e.g. JSON to save the current configuration for debugging.Pull Request Check List
main
branch – use a separate branch!docs/core-concepts.md
or one of the integration guides by hand.versionadded
,versionchanged
, ordeprecated
directives..rst
and.md
files is written using semantic newlines.