This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
align ilp over http custom settings #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style should match property definition in issue #383 removed deprecated incomingHttpLinkSettings and outgoingHttpLinkSettings accessors Signed-off-by: nhartner <[email protected]>
style should match property definition in issue #383 removed deprecated incomingHttpLinkSettings and outgoingHttpLinkSettings accessors Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
It was getting difficult to provide meaning error messages for missing fields without knowing the intention of what type of settings were being provided Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
does not strictly require it to be a url and in the case of auth0, it's not a url for web flows Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
sappenin
requested review from
theotherian and
sappenin
and removed request for
theotherian
…ings Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
Signed-off-by: nhartner <[email protected]>
…ing/hashCode etc Signed-off-by: nhartner <[email protected]>
don't need to log authType either since it's not used Signed-off-by: nhartner <[email protected]>
nkramer44
pushed a commit
that referenced
this pull request
Jan 28, 2020
* align Ilp-over-http custom settings to match update property style style should match property definition in issue #383 removed deprecated incomingHttpLinkSettings and outgoingHttpLinkSettings accessors Signed-off-by: nhartner <[email protected]> * align Ilp-over-http custom settings to match update property style style should match property definition in issue #383 removed deprecated incomingHttpLinkSettings and outgoingHttpLinkSettings accessors Signed-off-by: nhartner <[email protected]> * guava android compatibility fix Signed-off-by: nhartner <[email protected]> * remove unsed SharedSecretTokenSettings Signed-off-by: nhartner <[email protected]> * bringing back AuthType on settings. It was getting difficult to provide meaning error messages for missing fields without knowing the intention of what type of settings were being provided Signed-off-by: nhartner <[email protected]> * disable docker container logs Signed-off-by: nhartner <[email protected]> * remove fallback logic to deprecated property that no longer exists Signed-off-by: nhartner <[email protected]> * make jwt.token_audience a string instead of url because the JWT RFC does not strictly require it to be a url and in the case of auth0, it's not a url for web flows Signed-off-by: nhartner <[email protected]> * fix typo Signed-off-by: nhartner <[email protected]> * fix javadoc to include auth_type as a required property Signed-off-by: nhartner <[email protected]> * remove deprecated fallback that has been removed Signed-off-by: nhartner <[email protected]> * Only require an outgoing url for IlpOverHttpLink instead of link settings Signed-off-by: nhartner <[email protected]> * nuke deprecated constructor Signed-off-by: nhartner <[email protected]> * fix typo Signed-off-by: nhartner <[email protected]> * make toCustomSettingsMap auxiliary so it doesn't get include in toString/hashCode etc Signed-off-by: nhartner <[email protected]> * fix testConnection to not use linkSettings and just use outgoingUrl don't need to log authType either since it's not used Signed-off-by: nhartner <[email protected]> Signed-off-by: nkramer44 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use new customSetting property names as defined in #383
refactored the incoming/outgoingSettings such that simple or jwt auth settings are provided as separate objects
add JWT_RS_256 as an authType and added validation to require subject/audience/issuer when using JWT_RS_256
changed tokenAudience to be a String rather than HttpUrl because although it is often a URL, the JWT RFC allows for non-url audiences and in the case of Auth0 the audience is not a URL by default
Fixes issue #383