[WIP] add async translation support for enovim; Ref: #18 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianva
approved these changes
May 1, 2018
ianva
added a commit
that referenced
this pull request
May 1, 2018
ianva
pushed a commit
that referenced
this pull request
May 1, 2018
|
I test the new feature, but it can't work in my system. So I reverted and moved to new branch dev-async. Thanks for your pull request, I think you can manage to complete well. |
|
What's your system and vim version? Maybe I could add the support for vim8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async translation is implemented via job, which is supported by neovim and vim8.
This pull request works for neovim now, while still need code change to support vim8