Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instructions for last portion of walk leg #287

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Jan 10, 2025

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR improves instructions on walk legs after the last turn is taken:

  • "Continue" instructions, instead of "NO_INSTRUCTION", are given on the last street/sidewalk/path,
  • If the destination is away from the last street/sidewalk/path in an itinerary, an instruction: "Your destination is in the vicinity" is emitted when the traveler reaches the end of the leg shape. (An extra step is added behind the scenes to accommodate that).

Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 These look good.

@binh-dam-ibigroup binh-dam-ibigroup merged commit d742521 into dev Jan 23, 2025
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-snap-to-waypoint branch January 23, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants