feat(api): improve map() #9459
Closed
feat(api): improve map() #9459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works towards ibis-project#8289 One this is adding support for passing in None. These use the new `ibis.null(<type>)` API to return `op.Literal(None, <type>)`s Also, now map() is idempotent: you can pass in existing Expressions into map(). The type argument for all of these now always has an effect, not just when passing in python literals. So basically it acts like a cast if the argument is already an expression. You can test this locally with eg `pytest -m <backend> -k factory ibis/backends/tests/test_map.py`
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
I would like to close out the Map, Array and Struct API improvement PRs and start over with just one of them, with a very specific use case that doesn't work, and try to address that incrementally. These PRs are all interdependent and stuffed full of hugely-consequential API changes. |
|
sounds good, let's start with array for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works towards #8289
depends on the new array API of #9458
One this is adding support for passing in None.
These use the new
ibis.null(<type>)API to returnop.Literal(None, <type>)sAlso, now map() is idempotent: you can
pass in existing Expressions into map().
The type argument for all of these now always has an effect, not just when passing in python literals. So basically it acts like a cast if the argument is already an expression.
You can test this locally with eg
pytest -m <backend> -k factory ibis/backends/tests/test_map.py