Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: allow to customize install locations #57

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

junghans
Copy link
Contributor

No description provided.

@mkstoyanov
Copy link
Collaborator

I like the change but there are two more places that need to be updated:

  • the python path where the module is looking for the shared library
  • the post-install tests in test/post_install_test.cmake.sh lines 22 and 29

Copy link
Collaborator

@mkstoyanov mkstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should pass the CI now.

@junghans
Copy link
Contributor Author

I like the change but there are two more places that need to be updated:

  • the python path where the module is looking for the shared library
  • the post-install tests in test/post_install_test.cmake.sh lines 22 and 29

Done. I changed it from CMAKE_INSTALL_* to CMAKE_INSTALL_FULL_* in some places to force it to be an absolute path.

@junghans
Copy link
Contributor Author

Hmm, test fails as lib is hardcoded here:
https://github.com/spack/spack/blob/7ecdc175ff41d0039be1652642dbc5acb4c9e167/var/spack/repos/builtin/packages/heffte/package.py#L145C9-L145C85
but heffte now gets installed in lib64.

@mkstoyanov
Copy link
Collaborator

Hmm, test fails as lib is hardcoded here: https://github.com/spack/spack/blob/7ecdc175ff41d0039be1652642dbc5acb4c9e167/var/spack/repos/builtin/packages/heffte/package.py#L145C9-L145C85 but heffte now gets installed in lib64.

Good catch. I will update the spack package to put it back in lib. I think all xSDK packages used to default to lib as a requirement (don't know if it's still a valid one).

We can merge this one meanwhile, this is only relevant towards @develop builds.

@junghans
Copy link
Contributor Author

Hmm, test fails as lib is hardcoded here: https://github.com/spack/spack/blob/7ecdc175ff41d0039be1652642dbc5acb4c9e167/var/spack/repos/builtin/packages/heffte/package.py#L145C9-L145C85 but heffte now gets installed in lib64.

Good catch. I will update the spack package to put it back in lib. I think all xSDK packages used to default to lib as a requirement (don't know if it's still a valid one).

We can merge this one meanwhile, this is only relevant towards @develop builds.

I did a git grep through all the package.py and the majority have lib64 hard-coded, but some still have lib.

@mkstoyanov mkstoyanov merged commit 5e8d7c7 into icl-utk-edu:master Oct 17, 2024
6 of 10 checks passed
@junghans junghans deleted the cmake_install branch October 17, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants