Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling the error checking the benchmark #76

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mkstoyanov
Copy link
Collaborator

The benchmark sanity error check compares the result from a forward and inverse transforms against the original input. However, the data is not reset between the repetitions, which will create more work (memcopy) and may skew the benchmark. Combined with many runs, e.g., 2000 runs with single precision in 128^3 problems, the error may exceed the tolerance. In addition, the error check uses another MPI_Allreduce(), which is not counted in the total timing but can still take a while.

  • added a flag to skip the error checking in the benchamrk.

@mkstoyanov mkstoyanov merged commit dd2f610 into icl-utk-edu:master Feb 21, 2025
10 checks passed
@mkstoyanov mkstoyanov deleted the better_benchmrk_error branch February 21, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant