Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spack package file #9

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

G-Ragghianti
Copy link
Contributor

This is the package file that will be used to install fiber within spack. It is good to have this in the same repo as the main code so that the spack package can be updated in sync with the code base. The package.py is base don Piotr's previous work, but after working on it for a while I realized that the fft library would be better represented as a multi-value variant instead of separate variants for each library. One reason this is better is that it allows us to easily iterate over the list of supported libraries to reduce redundant configs in the package definition.

@G-Ragghianti G-Ragghianti requested a review from luszczek October 4, 2021 06:09
Copy link
Contributor

@luszczek luszczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for CI? This is too early in development to have a Spack package but if CI gets simplified then why not.

@G-Ragghianti
Copy link
Contributor Author

Is this needed for CI? This is too early in development to have a Spack package but if CI gets simplified then why not.

It isn't needed for CI, but I don't see any reason to not store the code right now in the repo even if we aren't going to immediately submit it to upstream spack. By writing the spack package to work with the current cmake build, it helped me to understand how the cmake may be improved to make it work better with spack.

@af-ayala af-ayala merged commit f264aa5 into icl-utk-edu:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants