Fix for ROCm SMI #143
Merged
Fix for ROCm SMI #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
force-pushed
the
2023.12.19_rocm-smi-fix
branch
2 times, most recently
from
e8257dc to
fea07e8
Compare
adanalis
approved these changes
Dec 20, 2023
The configure script used to search for rocm_smi headers in PAPI_ROCM_ROOT instead of PAPI_ROCMSMI_ROOT. This was because the rocm headers are typically installed under the same root. However, with rocm-6.0.0 the rocm_smi.h causes a failure while building the sysdetect component in PAPI (component that is enabled by default). Thus, we now look explicitly for the rocm_smi header in PAPI_ROCMSMI_ROOT instead in order to isolate the sysdetect & rocm components from rocm_smi.
The path of hipcc in the ROCm installation directory has changed. In order to be location independent the rocm/tests Makefile should locate the hipcc compiler in the installation directory rather than relying on a fixed pathname.
gcongiu
force-pushed
the
2023.12.19_rocm-smi-fix
branch
from
fea07e8 to
89793b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
ROCm 6.0.0 causes the build process to fail with an error due to a bug in the rocm_smi header. The sysdetect component is always built by default in PAPI and it uses the rocm_smi headers when these are available through the PAPI_ROCM_ROOT environment variable. This PR isolates the problem to the rocm_smi component by looking for the headers in PAPI_ROCMSMI_ROOT instead. The reason PAPI_ROCM_ROOT was used previously is that the rocm_smi headers are normally installed under the same rocm installation directory as other packages (e.g. HSA and Rocprofiler).
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests