cat: fix compile-time error #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
reviewed
Dec 20, 2023
| @@ -832,6 +832,7 @@ void exec_flops( int precision, int EventSet, FILE *fp ) { | |||
| #endif | |||
| break; | |||
| default: | |||
| break; | |||
| } | |||
There was a problem hiding this comment.
There should not be any need for break in default
There was a problem hiding this comment.
Should I use an empty statement instead; as in, just a semicolon?
dbarry9
force-pushed
the
2023.12.19_cat-flops-compiler-error
branch
from
34d0b23 to
228a272
Compare
gcongiu
approved these changes
Dec 20, 2023
On some older versions of GCC (10.3.0), not having a statement after 'default' in a switch-case statement can yield the compiler warning: "label at end of compound statement" These changes fix this error and have been tested on the AMD Zen3 architecture.
gcongiu
force-pushed
the
2023.12.19_cat-flops-compiler-error
branch
from
228a272 to
13a589b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some older versions of GCC (10.3.0), not having at least a 'break' in a switch-case statement can yield the compiler warning: "label at end of compound statement"
These changes fix this error and have been tested on the AMD Zen3 architecture.
Pull Request Description
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests