Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating error messages for function check_exclude_guest() in perf_event.c #308

Conversation

Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Jan 27, 2025

Pull Request Description

As stands, if a failure occurs in check_exclude_guest then one of the following errors will output:

Couldn't open hw_instructions in exclude_guest=0 test.
or
Couldn't open hw_instructions in exclude_guest=1 test.

This PR updates both error messages to include:

Set /proc/sys/kernel/perf_event_paranoid to 2 (or less) or run as root.

Such that it indicates to users this is a perf_event_paranoid issue.

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

@Treece-Burgess Treece-Burgess added component-perf_event PRs and Issues related to the perf_event component status-ready-for-review PR is ready to be reviewed labels Jan 27, 2025
@Treece-Burgess Treece-Burgess changed the title Updating error message for function check_exclude_guest() in perf_event.c Updating error messages for function check_exclude_guest() in perf_event.c Jan 27, 2025
@Treece-Burgess Treece-Burgess force-pushed the 01-26-25-exclude-guest-message branch from aec7a4c to 03183b7 Compare February 8, 2025 22:56
@Treece-Burgess Treece-Burgess merged commit 9778cec into icl-utk-edu:master Feb 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-perf_event PRs and Issues related to the perf_event component status-ready-for-review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants