Cuda : Statistic Qualifier #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djwoun
force-pushed
the
cuda_qual
branch
3 times, most recently
from
0786bce to
dfcc28e
Compare
Treece-Burgess
added
status-ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adding new statistic qualifier to the CUDA component.
Modified cuda component test script to fit the new event names.
Modified cuda component's event table. Hash table key's with name without stat value. The table value now contains the struct StringVector for stats.
Created StringVector struct to use a string vector for statistic values.
Data type changes for functions(use 32bits)
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
Cuda Component Tests
Hopper1:master 12 Pass 1 Fail
Hopper1:cuda_qual 12 Pass 1 Fail
Methane:master 12 Pass 1 Fail
Methane:cuda_qual 13 Pass 0 Fail
leconte:master 8 Pass 5 Fail
leconte:cuda_qual 8 Pass 5 Fail
The PR needs to pass all the tests