Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libpfm4 to Commit ID 762ca94 #316

Merged

Conversation

Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Feb 11, 2025

Current with
commit 762ca94010d9a8f21f0440c0b5807e9a2e849420
Author: Stephane Eranian [email protected]
Date: Sat Oct 19 15:34:10 2024 -0700

Cleanup Alderlake event descriptions

Remove . at end of descriptions.
Signed-off-by: Stephane Eranian <[email protected]>

commit 66627c778115b7d5a1cd6200250b7c4b07bccc67
Author: Stephane Eranian [email protected]
Date: Sun Feb 9 20:52:37 2025 -0800

Add Intel GraniteRapids uncore IMC PMU support

Adds Intel GraniteRapids uncore IMC (memory controller) PMU support.
  - Based on Intel JSON event table version   : 1.06
  - Based on Intel JSON event table published : 01/17/2025

Available at github.com/Intel/perfmon

Signed-off-by: Stephane Eranian <[email protected]>

commit 59aae0f5ce1dda4013063a4d192ab793179916d6
Author: Stephane Eranian [email protected]
Date: Sun Feb 9 17:04:11 2025 -0800

Fix clang unused function/variable errors

With clang and -Werrors, the library did not compile.
Fix both issues:
        - unused perf_get_ovfl_umask_idx() with CONFIG_PFMLIB_NOTRACEPOINT set
        - unused variable sum in self_smpl_multi.c

Signed-off-by: Stephane Eranian <[email protected]>

commit 876528e6213b478986ba2fef768ee7e06df0e5fd
Author: Stephane Eranian [email protected]
Date: Sun Feb 9 16:07:40 2025 -0800

Update Intel GraniteRapids core events to 1.06

Updates the Intel GraniteRapids core PMU event table
to latest Intel released version:

Date   : 01/17/2025
Version: 1.06

From gitub.com/Intel/perfmon

Signed-off-by: Stephane Eranian <[email protected]>

Note:

At this time the PAPI team does not have access to a machine with Intel GraniteRapids or Intel Alderlake to test Commit ID's:
- 762ca94
- 66627c7
- 876528e

As a sanity check, PAPI was built on a Intel SkyLake (Intel(R) Xeon(R) Gold 6140) with the utilities behaving as expected.

Commit ID 59aae0f does resolve the issue of being unable to compile libpfm4 with llvm compilers. Tested with llvm 11.1.0.

Pull Request Description

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

Current with
commit 762ca94010d9a8f21f0440c0b5807e9a2e849420
Author: Stephane Eranian <[email protected]>
Date:   Sat Oct 19 15:34:10 2024 -0700

    Cleanup Alderlake event descriptions

    Remove . at end of descriptions.
    Signed-off-by: Stephane Eranian <[email protected]>

commit 66627c778115b7d5a1cd6200250b7c4b07bccc67
Author: Stephane Eranian <[email protected]>
Date:   Sun Feb 9 20:52:37 2025 -0800

    Add Intel GraniteRapids uncore IMC PMU support

    Adds Intel GraniteRapids uncore IMC (memory controller) PMU support.
      - Based on Intel JSON event table version   : 1.06
      - Based on Intel JSON event table published : 01/17/2025

    Available at github.com/Intel/perfmon

    Signed-off-by: Stephane Eranian <[email protected]>

commit 59aae0f5ce1dda4013063a4d192ab793179916d6
Author: Stephane Eranian <[email protected]>
Date:   Sun Feb 9 17:04:11 2025 -0800

    Fix clang unused function/variable errors

    With clang and -Werrors, the library did not compile.
    Fix both issues:
            - unused perf_get_ovfl_umask_idx() with CONFIG_PFMLIB_NOTRACEPOINT set
            - unused variable sum in self_smpl_multi.c

    Signed-off-by: Stephane Eranian <[email protected]>

commit 876528e6213b478986ba2fef768ee7e06df0e5fd
Author: Stephane Eranian <[email protected]>
Date:   Sun Feb 9 16:07:40 2025 -0800

    Update Intel GraniteRapids core events to 1.06

    Updates the Intel GraniteRapids core PMU event table
    to latest Intel released version:

    Date   : 01/17/2025
    Version: 1.06

    From gitub.com/Intel/perfmon

    Signed-off-by: Stephane Eranian <[email protected]>

Note:

At this time the PAPI team does not have access to a machine with
Intel GraniteRapids or Intel Alderlake to test Commit ID's:
    - 762ca94
    - 66627c7
    - 876528e

As a sanity check, PAPI was built on a Intel SkyLake (Intel(R) Xeon(R) Gold 6140) with the
utilities behaving as expected.

Commit ID 59aae0f does resolve the issue of being unable to compile libpfm4 with llvm compilers.
Tested with llvm 11.1.0.
@Treece-Burgess Treece-Burgess added update-libpfm4 PRs related to adding the latest libpfm4 to PAPI status-ready-for-review PR is ready to be reviewed labels Feb 11, 2025
@Treece-Burgess Treece-Burgess linked an issue Feb 11, 2025 that may be closed by this pull request
@Treece-Burgess Treece-Burgess merged commit 489db60 into icl-utk-edu:master Feb 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-ready-for-review PR is ready to be reviewed update-libpfm4 PRs related to adding the latest libpfm4 to PAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile libpfm4 with latest LLVM compilers
2 participants