test: fix order of deleting arrays to resolve compiler warning (gcc 1…

…4.2)
icl-utk-edu · Dec 28, 2024 · 95a481c · 95a481c
1 parent 409c42a
commit 95a481c
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 16 deletions.
diff --git a/unit_test/test_HermitianMatrix.cc b/unit_test/test_HermitianMatrix.cc
@@ -362,21 +362,27 @@ void test_HermitianMatrix_fromDevices()
         }
     }
 
-    for (int dev = 0; dev < num_devices; ++dev) {
-        blas::device_free(Aarray[dev], *dev_queues[dev]);
-    }
-    delete[] Aarray;
-
     //----------
     // uplo=General fails
     test_assert_throw(
         slate::HermitianMatrix<double>::fromDevices(
             blas::Uplo::General, n, Aarray, num_devices, lda, nb, p, q, mpi_comm ),
         slate::Exception);
 
-    // free the device specific queues
-    for (int dev = 0; dev < num_devices; ++dev)
-        delete dev_queues[dev];
+    //----------
+    // Free arrays.
+    for (int dev = 0; dev < num_devices; ++dev) {
+        blas::device_free( Aarray[ dev ], *dev_queues[ dev ] );
+        Aarray[ dev ] = nullptr;
+    }
+    delete[] Aarray;
+    Aarray = nullptr;
+
+    // Free the device specific queues.
+    for (int dev = 0; dev < num_devices; ++dev) {
+        delete dev_queues[ dev ];
+        dev_queues[ dev ] = nullptr;
+    }
 }
 
 //==============================================================================

diff --git a/unit_test/test_SymmetricMatrix.cc b/unit_test/test_SymmetricMatrix.cc
@@ -362,21 +362,27 @@ void test_SymmetricMatrix_fromDevices()
         }
     }
 
-    for (int dev = 0; dev < num_devices; ++dev) {
-        blas::device_free(Aarray[dev], *dev_queues[dev]);
-    }
-    delete[] Aarray;
-
     //----------
     // uplo=General fails
     test_assert_throw(
         slate::SymmetricMatrix<double>::fromDevices(
             blas::Uplo::General, n, Aarray, num_devices, lda, nb, p, q, mpi_comm ),
         slate::Exception);
 
-    // free the device specific queues
-    for (int dev = 0; dev < num_devices; ++dev)
-        delete dev_queues[dev];
+    //----------
+    // Free arrays.
+    for (int dev = 0; dev < num_devices; ++dev) {
+        blas::device_free( Aarray[ dev ], *dev_queues[ dev ] );
+        Aarray[ dev ] = nullptr;
+    }
+    delete[] Aarray;
+    Aarray = nullptr;
+
+    // Free the device specific queues.
+    for (int dev = 0; dev < num_devices; ++dev) {
+        delete dev_queues[ dev ];
+        dev_queues[ dev ] = nullptr;
+    }
 }
 
 //==============================================================================