Avoid allocating unneeded host tile #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
neil-lindquist
force-pushed
the
neil/cleanup-gpu-mpi
branch
from
44dd967 to
35bf993
Compare
neil-lindquist
force-pushed
the
neil/cleanup-gpu-mpi
branch
2 times, most recently
from
b75bdea to
541263b
Compare
neil-lindquist
force-pushed
the
neil/cleanup-gpu-mpi
branch
from
541263b to
98d0feb
Compare
neil-lindquist
force-pushed
the
neil/cleanup-gpu-mpi
branch
from
98d0feb to
09f7d2b
Compare
neil-lindquist
force-pushed
the
neil/cleanup-gpu-mpi
branch
from
09f7d2b to
3ccb895
Compare
mgates3
approved these changes
Jan 5, 2024
mgates3
added a commit
that referenced
this pull request
Jan 5, 2024
Commits that didn't get pushed to #122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the discussion on #113 about not allocating a host tile when using GPU-aware MPI.
Changes:
tileSendto send directly from any valid tile instance when using GPU-aware MPItileBcastToSetvariant that has asserted false for the last 4 yearstrsmAto receive tiles directly on deviceOn 4 nodes of Frontier w/ GPU-aware MPI, this PR improves
trsmAby about 10%.