-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of ttmqr and friends #127
Merged
neil-lindquist
merged 10 commits into
icl-utk-edu:master
from
neil-lindquist:neil/svd-heev-perf
Dec 13, 2023
Merged
Improve performance of ttmqr and friends #127
neil-lindquist
merged 10 commits into
icl-utk-edu:master
from
neil-lindquist:neil/svd-heev-perf
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df2881e
to
4675e8f
Compare
66bfc8c
to
63eb7ed
Compare
63eb7ed
to
f822c77
Compare
f822c77
to
8c889c9
Compare
cayrols
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me. I did not double check in details the ttmqr
case as it is very similar to the ttmlq
one.
e3fd2ae
to
7cc42e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the available parallelism in
ttmqr
,ttmlq
, andhettmqr
. Additionally, I cleaned up a few minor things insrc/he2hb.cc
.Speedups for various routines on 8 nodes of Frontier with CPU-only MPI and
--origin d --target d --dim 100000
(plus some warm up sizes).