Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of ttmqr and friends #127

Merged
merged 10 commits into from
Dec 13, 2023

Conversation

neil-lindquist
Copy link
Contributor

@neil-lindquist neil-lindquist commented Oct 11, 2023

This increases the available parallelism in ttmqr, ttmlq, and hettmqr. Additionally, I cleaned up a few minor things in src/he2hb.cc.

Speedups for various routines on 8 nodes of Frontier with CPU-only MPI and --origin d --target d --dim 100000 (plus some warm up sizes).

Routine Speedup
he2hb 1.17x
ge2tb 1.47x
unmqr 1.07x

@neil-lindquist neil-lindquist force-pushed the neil/svd-heev-perf branch 2 times, most recently from df2881e to 4675e8f Compare October 12, 2023 13:28
@mgates3 mgates3 changed the title Improve performance of ttmqr and friends (depends on #124) Improve performance of ttmqr and friends (depends on #123) Oct 12, 2023
@neil-lindquist neil-lindquist force-pushed the neil/svd-heev-perf branch 2 times, most recently from 66bfc8c to 63eb7ed Compare October 17, 2023 20:12
@neil-lindquist neil-lindquist changed the title Improve performance of ttmqr and friends (depends on #123) Improve performance of ttmqr and friends Nov 16, 2023
@mgates3 mgates3 requested a review from cayrols November 21, 2023 15:37
Copy link
Contributor

@cayrols cayrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me. I did not double check in details the ttmqr case as it is very similar to the ttmlq one.

@neil-lindquist neil-lindquist merged commit f2b0cda into icl-utk-edu:master Dec 13, 2023
7 of 8 checks passed
@neil-lindquist neil-lindquist deleted the neil/svd-heev-perf branch December 13, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants