Refactoring Matrix Generation Library in Slate #145

Treece-Burgess · 2023-11-16T16:58:16Z

Refactor current SLATE matrix generation into its own library.

matgen/generate_matrix_tz.cc

matgen/generate_matrix_he.cc

matgen/generate_type_ij.hh

matgen/generate_type_gfpp.hh

matgen/matrix_utils.hh

mgates3

Some stylistic changes, but overall looks right.

matgen/generate_matrix.hh

matgen/generate_matrix_ge.cc

matgen/generate_type_rand.hh

matgen/generate_type_svd.hh

matgen/set_lambdas.cc

matgen/generate_matrix_he_and_tz.cc

matgen/set_lambdas.hh

CMakeLists.txt

matgen/generate_matrix_he_and_tz.cc

matgen/generate_matrix.hh

mgates3

Some more feedback. I didn't look at everything. A lot of these comments are about how the include files are structured and included.

include/slate/generate_matrix.hh

matgen/generate_matrix_ge.cc

matgen/generate_matrix_utils.hh

matgen/matgen_params.hh

src/set_lambdas.cc

test/matgen.hh

matgen/generate_matrix_utils.cc

src/set_lambdas.cc

test/matgen.hh

matgen/testsweeper.hh

test/matrix_params.cc

mgates3

Looks good! A few minor things to cleanup or think about. I'll fix these.

CMakeLists.txt

matgen/matgen_label.cc

matgen/generate_sigma.hh

matgen/generate_matrix_he_and_tz.cc

matgen/generate_matrix_ge.cc

…d a small code snippet to generate_matrix_tz.cc.

…s configure_seed, decode_matrix, etc.

…ngle file.

…ges in PR comments.

…late.hh, and moved genearte_matrix.hh to include directory.

…dating test routines to include matgen.hh.

…random.cc and random.hh to matgen directory, and cleanup of files.

…ving testsweeper.hh into matgen directory such that genearte_matrix_utils.cc does not rely on testsweeper.

… lambda function.

… ANSI color codes into file.

…void nan comparison.

src/set_lambdas.cc

mgates3 · 2024-02-05T01:58:51Z

If someone wants to look over my changes, that would be great. Otherwise I'll merge it in sometime this week.

neil-lindquist

Your changes look good to me. The only issue that I still see in the overall PR is some unnecessary #include's. For example, chrono is included in most of the matgen CC files, but only used in matgen/generate_matrix_utils.cc. But, that's not a huge issue.

neil-lindquist reviewed Nov 16, 2023

View reviewed changes

matgen/generate_matrix_tz.cc Outdated Show resolved Hide resolved

matgen/generate_matrix_he.cc Outdated Show resolved Hide resolved

matgen/generate_type_ij.hh Outdated Show resolved Hide resolved

matgen/generate_type_gfpp.hh Outdated Show resolved Hide resolved

neil-lindquist added the Draft label Nov 16, 2023

Treece-Burgess requested a review from mgates3 November 16, 2023 20:42

Treece-Burgess commented Nov 16, 2023

View reviewed changes

matgen/matrix_utils.hh Outdated Show resolved Hide resolved

mgates3 requested changes Nov 21, 2023

View reviewed changes

Treece-Burgess commented Dec 1, 2023

View reviewed changes

matgen/generate_matrix_he_and_tz.cc Show resolved Hide resolved

Treece-Burgess commented Dec 1, 2023

View reviewed changes

matgen/generate_matrix_he_and_tz.cc Show resolved Hide resolved

neil-lindquist reviewed Dec 1, 2023

View reviewed changes

matgen/set_lambdas.hh Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

matgen/generate_matrix_he_and_tz.cc Show resolved Hide resolved

matgen/generate_matrix.hh Outdated Show resolved Hide resolved

neil-lindquist mentioned this pull request Dec 5, 2023

Remove tile life infrastructure #151

Merged

mgates3 requested changes Dec 20, 2023

View reviewed changes

neil-lindquist reviewed Dec 20, 2023

View reviewed changes

matgen/generate_matrix_utils.cc Outdated Show resolved Hide resolved

src/set_lambdas.cc Outdated Show resolved Hide resolved

src/set_lambdas.cc Outdated Show resolved Hide resolved

test/matgen.hh Outdated Show resolved Hide resolved

neil-lindquist reviewed Dec 28, 2023

View reviewed changes

matgen/testsweeper.hh Outdated Show resolved Hide resolved

test/matrix_params.cc Outdated Show resolved Hide resolved

Treece-Burgess removed the Draft label Dec 29, 2023

Treece-Burgess marked this pull request as ready for review December 29, 2023 15:31

mgates3 requested changes Feb 4, 2024

View reviewed changes

Treece Burgess added 15 commits February 4, 2024 13:27

First commit for matrix generation refactor.

72bd38b

Adding lambda functions for matrix types gfpp and ij. As well as adde…

ba6b513

…d a small code snippet to generate_matrix_tz.cc.

Commiting generate_sigma header and matrix_utils header which contain…

00872b9

…s configure_seed, decode_matrix, etc.

Combining geev and geevx into a single file (generate_type_geev.hh).

013de1a

Combining hermitian and trapezoid matrix generation files into one si…

286f981

…ngle file.

Renaming matrix_utils.hh header file.

06979e2

Updating matgen library with new code changes and requested code chan…

5b0b726

…ges in PR comments.

Removing unnecessary includes, added set forward declaration inside s…

6c6d681

…late.hh, and moved genearte_matrix.hh to include directory.

Adding matgen class to convert matrix params to matgen params, and up…

62ca6f5

…dating test routines to include matgen.hh.

Moved generate_label() to be included within matgen directory, moved …

bafd4de

…random.cc and random.hh to matgen directory, and cleanup of files.

Moving matgen_params.hh into include/slate/generate_matrix.hh, and mo…

6bc0bd0

…ving testsweeper.hh into matgen directory such that genearte_matrix_utils.cc does not rely on testsweeper.

Deleting generate_type_jordan.hh.

19d1afe

Updated jordan matrix type within generate_matrix_he_and_tz.cc to use…

2280992

… lambda function.

Adding lambda function for jordan for hermitian/trapezoid function.

b4f34c1

Moving trapezoid rand matrix type to generate_type_rand.hh.

a3c67cc

Treece Burgess and others added 5 commits February 4, 2024 13:42

Removing testsweeper dependency in generate_matrix_utils.cc by adding…

ce5ebcb

… ANSI color codes into file.

Changing rho from int64_t to double.

7ff0a79

Adding additional target compile option for slate matgen library to a…

a08dea5

…void nan comparison.

Add matgen to Makefile

3455330

Updating for loop in random V section of generate_type_svd.hh.

5f4db2a

mgates3 force-pushed the matgen branch 2 times, most recently from 4a14a81 to 35f9053 Compare February 4, 2024 20:09

mgates3 added 6 commits February 4, 2024 20:35

matgen: Add copyright, space, comments, use r_one per style guide

541cedc

matgen: Move labels back to test directory.

032824e

matgen: Add jordanT matrix type.

923b344

matgen: remove redundant calls

63035b7

cmake: group like options

c68f075

set: fix BaseTrapezoid to check uplo

9415f49

mgates3 force-pushed the matgen branch from b24a456 to 9415f49 Compare February 5, 2024 01:51

mgates3 approved these changes Feb 5, 2024

View reviewed changes

src/set_lambdas.cc Show resolved Hide resolved

neil-lindquist approved these changes Feb 6, 2024

View reviewed changes

mgates3 merged commit 5b23aa5 into icl-utk-edu:master Feb 8, 2024
8 checks passed

uthpalaherath mentioned this pull request Feb 11, 2024

Python generated slate_module.f90 gives "This is an incorrect value for a kind type parameter in this context" error #163

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring Matrix Generation Library in Slate #145

Refactoring Matrix Generation Library in Slate #145

Treece-Burgess commented Nov 16, 2023 •

edited by mgates3

Loading

mgates3 left a comment

mgates3 left a comment

mgates3 left a comment

mgates3 commented Feb 5, 2024

neil-lindquist left a comment

Refactoring Matrix Generation Library in Slate #145

Refactoring Matrix Generation Library in Slate #145

Conversation

Treece-Burgess commented Nov 16, 2023 • edited by mgates3 Loading

mgates3 left a comment

Choose a reason for hiding this comment

mgates3 left a comment

Choose a reason for hiding this comment

mgates3 left a comment

Choose a reason for hiding this comment

mgates3 commented Feb 5, 2024

neil-lindquist left a comment

Choose a reason for hiding this comment

Treece-Burgess commented Nov 16, 2023 •

edited by mgates3

Loading