Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C and Fortran APIs plus add svd, eig, rcondest, and copy functions #148

Merged
merged 16 commits into from
Dec 14, 2023

Conversation

neil-lindquist
Copy link
Contributor

@neil-lindquist neil-lindquist commented Nov 28, 2023

Fixes to the C/Fortran APIs include

  • Fixing layout of C Tile object
  • Adding MOSI_State type
  • Avoid calling some deprecated functions
  • CMake didn't support the Fortran interface This wasn't working in the CI, so I removed it for future work.

Preventative fixes includes

  • Adding several static_asserts to detect things being out of sync
  • Compiling the C and Fortran APIs in the CI

Finally, I added svd w/ vectors, eig w/ vectors, rcondest, and copy (I wanted the last one for testing purposes.)

Copy link
Contributor

@cayrols cayrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note: I did not test tools/c_api/generate_util.py script to make sure it is correct.
Also, I did not check the LAPACK++ updates. But I suppose it got approved in the LAPACK++ repo.

@neil-lindquist neil-lindquist merged commit a82bcc1 into icl-utk-edu:master Dec 14, 2023
8 checks passed
@neil-lindquist neil-lindquist deleted the alt-apis branch December 14, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants