Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVD, Hermitian Eig, and condest to LAPACK and ScaLAPACK APIS #149

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Add SVD, Hermitian Eig, and condest to LAPACK and ScaLAPACK APIS #149

merged 11 commits into from
Dec 14, 2023

Conversation

neil-lindquist
Copy link
Contributor

I also fixed the tester's ScaLAPACK wrapper for p?pocon, which had an extra argument.

@ayarkhan ayarkhan assigned ayarkhan and unassigned ayarkhan Dec 12, 2023
cayrols
cayrols approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@cayrols cayrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I put a few comments that if addressed would apply to several similar files.

@neil-lindquist neil-lindquist merged commit f9ac8c7 into icl-utk-edu:master Dec 14, 2023
8 checks passed
@neil-lindquist neil-lindquist deleted the la-scala-apis branch December 14, 2023 21:13
@mgates3 mgates3 mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgates3 mgates3 mgates3 left review comments

@cayrols cayrols cayrols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neil-lindquist @mgates3 @cayrols @ayarkhan