Optimize class sizes #153
Merged
Optimize class sizes #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatrixStorage had an unused member (own), although it didn't affect length Tile was reorganized to go from 80 bytes to 72 bytes TileKind was changed to use char storage, this also simplified Debug.cc
Likely to leave the tile in an inconsistant state
It adds unnessary storage and instructions
Everything instantiates off Memory::num_devices_, so just use that directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some miscellaneous cleanup, particularly reducing the size of some classes.
Tile's member variables were reordered for better packing andTileKindwas switched tocharstorageTile::stride(int64_t)since it will break the layout management and removed the unused, internalTile::kind(TileKind)MatrixStoragestd::maps inMemoryw/std::vectorssince the keys are just0, 1, ..., num_devicesnum_devices_intoMemory::num_devices_. To assist this change, all of the accesses are replaced with calls to helper functions (which the compiler will inline).