Fix SVD for slightly tall matrices, and other fixes. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgates3
force-pushed
the
svd-fix-squarish
branch
from
5e9a943 to
015e55b
Compare
mgates3
force-pushed
the
svd-fix-squarish
branch
3 times, most recently
from
c0af335 to
c63ecda
Compare
…se (m >= n but not m >> n), time redistribution
…nd num_local_rows_cols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For slightly tall (m > n and not m >> n) matrices, the internal U and VT matrices were incorrectly sized. Uhat and U1 are m x n, U2 and U3 are n x n. This solved a bug that showed with
./run_tests.py --xsmall svd. Added more matrix sizes so--quickwould reveal the bug, too.Also cleaned up the code a lot, pulled out common chunks. Allocated more memory to eliminated one redistribution of VT3.
Removed unused Reflectors from
tb2bd. They were no longer needed after storing vectors in U and VT.[Merged some fixes separately in #183 that were originally included here.]