steqr #189
Merged
steqr #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgates3
commented
Jun 26, 2024
mgates3
force-pushed
the
steqr
branch
2 times, most recently
from
f9eff5b to
921b460
Compare
mgates3
commented
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steqr: Symmetric Tridiagonal Eigenvalues & vectors using the implicit QR iteration algorithm.
Replaces ScaLAPACK's Fortran
[sdcz]steqr2.fwith a templated C++ version,steqr_impl.cc. There's a high-level SLATE wrapper around it insteqr.cc. Being templated, this adds the lookahead that was in the[cz]steqr2to the real versions, which noticeably improves performance, although D&C is still much faster.Also renamed from steqr2 to steqr. The only reason ScaLAPACK used steqr2 was to avoid the name collision with LAPACK. SLATE inherently doesn't have a name collision.