Let he2hb assert its limitations rather than duplicating it upfront/call-side #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, there is a duplication of an assert. Doing it in heev triggers the exception as early as possible and avoids modifying the matrix A in heev before triggering the exception. The tester also currently assumes that heev does an assertion. That could be fixed by moving the "Test that invalid options throw" block after As this PR doesn't really fix a bug, I'm not inclined to make any changes. |
|
Let me close. It was an initial byproduct for something I am playing with. In essence, I am looking for PHEEVD to be supported with the Upper format (see #204 (comment)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.