Add gereduce #211
Open
Add gereduce #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expression; Style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling over an old PR from Bitbucket. See https://bitbucket.org/icl/slate-dev/pull-requests/195
Context
Dalal Sukkari is improving unmqr which needs a gereduce operation.
She added it but in order to have simpler PRs, I extracted her work that is only related to gereduce and created this branch.
This has been checked through unit test (test_geadd) that will be in a separate PR.
Idea
The idea of gereduce is to have a matrix A where the tiles of each block column are reduced into a tile of a matrix B such that:
where A has mt block rows and nt block columns, and B is of dimension 1 x nt.
Modification