Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency jsdom to v25 #20

Open
wants to merge 1 commit into
base: the-one
Choose a base branch
from
Open

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jsdom ^22.0.0 -> ^25.0.0 age adoption passing confidence

Release Notes

jsdom/jsdom (jsdom)

v25.0.1

Compare Source

  • Updated dependencies, notably tough-cookie, which no longer prints a deprecation warning.

v25.0.0

Compare Source

This major release changes the prototype of a jsdom's EventTarget.prototype to point to the Object.prototype inside the jsdom, instead of pointing to the Node.js Object.prototype. Thus, the prototype chain of Window stays entirely within the jsdom, never crossing over into the Node.js realm.

This only occurs when runScripts is set to non-default values of "dangerously" or "outside-only", as with the default value, there is no separate Object.prototype inside the jsdom.

This will likely not impact many programs, but could cause some changes in instanceof behavior, and so out of an abundance of caution, we're releasing it as a new major version.

v24.1.3

Compare Source

  • Fixed calls to postMessage() that were done as a bare property (i.e., postMessage() instead of window.postMessage()).

v24.1.2

Compare Source

  • Fixed an issue with the in operator applied to EventTarget methods, e.g. 'addEventListener' in window, which only appeared in Node.js ≥22.5.0. (legendecas)
  • Fixed the events fired by blur(): it no longer fires focus and focusin on the Document, and blur and focusout no longer have their relatedTarget property set. (asamuzaK)

v24.1.1

Compare Source

  • Fixed selection methods to trigger the selectionchange event on the Document object. (piotr-oles)

v24.1.0

Compare Source

  • Added the getSetCookie() method to the Headers class. (ushiboy)
  • Fixed the creation and parsing of elements with names from Object.prototype, like "constructor" or "toString".
  • Updated rweb-cssom, which can now parse additional CSS constructs.

v24.0.0

Compare Source

This release reverts our selector engine back to nwsapi. As discussed in #​3659, the performance regressions from @asamuzakjp/dom-selector turned out to be higher than anticipated. In the future, we can revisit @asamuzakjp/dom-selector after it reaches nwsapi's performance on the two real-world benchmarks provided by the community.

Since reverting to nwsapi causes several functionality regressions, e.g. removing :has() support, we've decided to make this a major version.

Additionally:

  • Small fixes to edge-case behavior of the following properties: input.maxLength, input.minLength, input.size, progress.max, tableCell.colSpan, tableCell.rowSpan, tableCol.span, textArea.cols, textArea.maxLength, textArea.minLength, textArea.rows.

v23.2.0

Compare Source

This release switches our CSS selector engine from nwsapi to @asamuzakjp/dom-selector. The new engine is more actively maintained, and supports many new selectors: see the package's documentation for the full list. It also works better with shadow trees.

There is a potential of a performance regression due to this change. In our stress test benchmark, which runs most of these 273 selectors against this 128 KiB document, the new engine completes the benchmark only 0.25x as fast. However, we're hopeful that in more moderate usage this will not be a significant issue. Any help speeding up @asamuzakjp/dom-selector is appreciated, and feel free to open an issue if this has had a significant impact on your project.

v23.1.0

Compare Source

  • Added an initial implementation of ElementInternals, including the shadowRoot getter and the string-valued ARIA properties. (zjffun)
  • Added the string-valued ARIA attribute-reflecting properties to Element.
  • Fixed history.pushState() and history.replaceState() to follow the latest specification, notably with regards to how they handle empty string inputs and what new URLs are possible.
  • Fixed the input.valueAsANumber setter to handle NaN correctly. (alexandertrefz)
  • Updated various dependencies, including cssstyle which contains several bug fixes.

v23.0.1

Compare Source

  • Fix incorrect canvas peer dependency.

v23.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Nov 16, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular-devkit/[email protected]
npm warn node_modules/@angular-devkit/build-angular
npm warn   dev @angular-devkit/build-angular@"^18.0.0" from the root project
npm warn   2 more (@analogjs/vite-plugin-angular, @nx/angular)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular-devkit/[email protected]
npm warn node_modules/@angular-devkit/build-angular
npm warn   dev @angular-devkit/build-angular@"^18.0.0" from the root project
npm warn   2 more (@analogjs/vite-plugin-angular, @nx/angular)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular-devkit/[email protected]
npm warn node_modules/@angular-devkit/build-angular
npm warn   dev @angular-devkit/build-angular@"^18.0.0" from the root project
npm warn   2 more (@analogjs/vite-plugin-angular, @nx/angular)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular/[email protected]
npm warn node_modules/@angular/compiler-cli
npm warn   dev @angular/compiler-cli@"^18.0.0" from the root project
npm warn   3 more (@angular-devkit/build-angular, @angular/build, @ngtools/webpack)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular/[email protected]
npm warn node_modules/@angular/compiler-cli
npm warn   dev @angular/compiler-cli@"^18.0.0" from the root project
npm warn   3 more (@angular-devkit/build-angular, @angular/build, @ngtools/webpack)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular/[email protected]
npm warn node_modules/@angular/compiler-cli
npm warn   dev @angular/compiler-cli@"^18.0.0" from the root project
npm warn   3 more (@angular-devkit/build-angular, @angular/build, @ngtools/webpack)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @angular/[email protected]
npm warn node_modules/@angular/compiler-cli
npm warn   dev @angular/compiler-cli@"^18.0.0" from the root project
npm warn   3 more (@angular-devkit/build-angular, @angular/build, @ngtools/webpack)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/typescript
npm warn   dev typescript@"~5.6.0" from the root project
npm warn   12 more (@angular-devkit/build-angular, @angular/build, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer typescript@">=5.4 <5.5" from @ngtools/[email protected]
npm warn node_modules/@ngtools/webpack
npm warn   peer @ngtools/webpack@"^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from @analogjs/[email protected]
npm warn   node_modules/@analogjs/vite-plugin-angular
npm warn   1 more (@angular-devkit/build-angular)
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: @angular/[email protected]
npm error node_modules/@angular/compiler
npm error   @angular/compiler@"^18.0.0" from the root project
npm error   peer @angular/compiler@"18.0.3" from @angular/[email protected]
npm error   node_modules/@angular/compiler-cli
npm error     dev @angular/compiler-cli@"^18.0.0" from the root project
npm error     peer @angular/compiler-cli@"^18.0.0" from @angular-devkit/[email protected]
npm error     node_modules/@angular-devkit/build-angular
npm error       dev @angular-devkit/build-angular@"^18.0.0" from the root project
npm error       2 more (@analogjs/vite-plugin-angular, @nx/angular)
npm error     2 more (@angular/build, @ngtools/webpack)
npm error   2 more (@angular/platform-browser-dynamic, @angular/platform-server)
npm error
npm error Could not resolve dependency:
npm error dev @analogjs/vite-plugin-angular@"^1.5.0" from the root project
npm error
npm error Conflicting peer dependency: @angular/[email protected]
npm error node_modules/@angular/compiler
npm error   peer @angular/compiler@"^19.0.0" from @angular/[email protected]
npm error   node_modules/@angular/build
npm error     peerOptional @angular/build@"^18.0.0 || ^19.0.0" from @analogjs/[email protected]
npm error     node_modules/@analogjs/vite-plugin-angular
npm error       dev @analogjs/vite-plugin-angular@"^1.5.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-12-09T08_47_51_822Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-12-09T08_47_51_822Z-debug-0.log

Copy link

coderabbitai bot commented Nov 16, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@renovate renovate bot changed the title Update dependency jsdom to v25 Update dependency jsdom to v25 - autoclosed Dec 8, 2024
@renovate renovate bot closed this Dec 8, 2024
@renovate renovate bot deleted the renovate/jsdom-25.x branch December 8, 2024 18:33
@renovate renovate bot changed the title Update dependency jsdom to v25 - autoclosed Update dependency jsdom to v25 Dec 9, 2024
@renovate renovate bot reopened this Dec 9, 2024
@renovate renovate bot force-pushed the renovate/jsdom-25.x branch from eaf0327 to 7fb6d3b Compare December 9, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants