add minver/maxver attributes to enum values #406
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
clarifications
|
Actually the default value should not be 1 but the |
|
Thats the same thing with the element attribute "minver" and "maxver" What is when this enum is removed in the next ebml-version... and what is when this enum returns in a next next version? |
|
Indeed, there's no reason to have one and not the other. I added both. |
hubblec4
reviewed
Apr 4, 2021
mbunkus
requested changes
May 30, 2021
robUx4
commented
Jun 6, 2021
hubblec4
approved these changes
Jun 6, 2021
|
@robUx4 can you change the title to |
robUx4
changed the title
retokromer
approved these changes
Jul 10, 2021
This allows adding new enum values without forcing old readers to support them. The explanation is copied from the minver attribute of "element"
This could allow deprecating enum values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding new enum values without forcing old readers to support them.
The explanation is copied from the minver attribute of "element"
This is necessary (IMO) to add new values like zstd compression