make ChapterDisplay use only one language at a time #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the discussion in ietf-wg-cellar/ebml-specification#409 It could be assumed that English is always present because ChapLanguage is mandatory and has a default value. To avoid this interpretation we should have one language (and one IETF variant) per ChapterDisplay item. We already have to use many ones per language. The merge of different values because they have the same value is unlikely (but it may exist in the real world).
|
libavformat doesn't use the element either when reading and always writes a single libwebm reads a single value (possibly leaking data if more than one value is found) and writes a single value. |
|
No this is not a bug and I totally disagree with this change. |
mbunkus
requested changes
May 30, 2021
There was a problem hiding this comment.
I've made my objections known in ietf-wg-cellar/ebml-specification#409 where we should keep the discussion about what to do until we reach consensus, I think.
|
OK with allowing multiple values although some clarifications are needed on the EBML side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in ietf-wg-cellar/ebml-specification#409
It could be assumed that English is always present because ChapLanguage is
mandatory and has a default value.
To avoid this interpretation we should have one language (and one IETF variant)
per ChapterDisplay item. We already have to use many ones per language. The merge
of different values because they have the same value is unlikely (but it may
exist in the real world).