Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated neimode parameter from bfs() and dfs() #1526

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Sep 24, 2024

originally planned for removal in 1.4.0

Fix #1105

Copy link
Contributor

aviator-app bot commented Sep 24, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Contributor

krlmlr commented Sep 26, 2024

Thanks, this is fine but let's wait for just until after the release.

@krlmlr
Copy link
Contributor

krlmlr commented Nov 7, 2024

Running revdepchecks.

@maelle
Copy link
Contributor Author

maelle commented Nov 28, 2024

is it time for this @krlmlr

@krlmlr
Copy link
Contributor

krlmlr commented Nov 28, 2024

Running revdepchecks again.

@krlmlr krlmlr changed the title chore!: remove deprecated neimode parameter from bfs / dfs; ori… chore!: remove deprecated neimode parameter from bfs() and dfs() Jan 9, 2025
@krlmlr krlmlr enabled auto-merge (squash) January 9, 2025 17:44
@krlmlr
Copy link
Contributor

krlmlr commented Jan 9, 2025

Thanks!

@krlmlr krlmlr merged commit 1499403 into main Jan 9, 2025
11 checks passed
@krlmlr krlmlr deleted the neimode branch January 9, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated neimode parameter from bfs / dfs; originally planned for removal in 1.4.0
2 participants