Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adapt handling of optional parameters to interface definition changes in the C core #1567

Merged
merged 6 commits into from
Jan 9, 2025
Merged

chore: Adapt handling of optional parameters to interface definition changes in the C core #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1942126
refactor: use OPTIONAL instead of =NULL consistently in functions-R.yaml
szhorvat Oct 31, 2024
6d7da22
refactor: use IGRAPH_R_CHECK at top-level error checking in auto-gene…
szhorvat Oct 31, 2024
7f9a3ed
fix: use NULL instead of 0 where appropriate in interface code and ad…
szhorvat Oct 31, 2024
4fe0cf8
fix: remove some unneeded null checks in the auto-generated code
szhorvat Oct 31, 2024
1e14e3b
fix: add another missing error check in auto-generated code
szhorvat Oct 31, 2024
52cc223
interface: re-add `NULL` default value for the `weights` parameter of…
szhorvat Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions R/aaa-auto.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ get_k_shortest_paths_impl <- function(graph, from, to, ..., k, weights=NULL, mod
res
}

get_widest_path_impl <- function(graph, from, to, weights, mode=c("out", "in", "all", "total")) {
get_widest_path_impl <- function(graph, from, to, weights=NULL, mode=c("out", "in", "all", "total")) {
# Argument checks
ensure_igraph(graph)
from <- as_igraph_vs(graph, from)
Expand Down Expand Up @@ -826,7 +826,7 @@ get_widest_path_impl <- function(graph, from, to, weights, mode=c("out", "in", "
res
}

get_widest_paths_impl <- function(graph, from, to=V(graph), weights, mode=c("out", "in", "all", "total")) {
get_widest_paths_impl <- function(graph, from, to=V(graph), weights=NULL, mode=c("out", "in", "all", "total")) {
# Argument checks
ensure_igraph(graph)
from <- as_igraph_vs(graph, from)
Expand Down Expand Up @@ -856,7 +856,7 @@ get_widest_paths_impl <- function(graph, from, to=V(graph), weights, mode=c("out
res
}

widest_path_widths_dijkstra_impl <- function(graph, from=V(graph), to=V(graph), weights, mode=c("out", "in", "all", "total")) {
widest_path_widths_dijkstra_impl <- function(graph, from=V(graph), to=V(graph), weights=NULL, mode=c("out", "in", "all", "total")) {
# Argument checks
ensure_igraph(graph)
from <- as_igraph_vs(graph, from)
Expand All @@ -878,7 +878,7 @@ widest_path_widths_dijkstra_impl <- function(graph, from=V(graph), to=V(graph),
res
}

widest_path_widths_floyd_warshall_impl <- function(graph, from=V(graph), to=V(graph), weights, mode=c("out", "in", "all", "total")) {
widest_path_widths_floyd_warshall_impl <- function(graph, from=V(graph), to=V(graph), weights=NULL, mode=c("out", "in", "all", "total")) {
# Argument checks
ensure_igraph(graph)
from <- as_igraph_vs(graph, from)
Expand Down
Loading
Loading