feat: get_edge_ids() accepts data frames and matrices

[krlmlr]

Also for add_edges() ?

The matrix case works already by accident, a two-row matrix will give the intended result. Should we soft-deprecate the matrix case to later support two-column matrices?

library(igraph)
set.seed(20250120)
g <- sample_gnp(20, 0.1)
g
#> IGRAPH dc0368b U--- 20 22 -- Erdos-Renyi (gnp) graph
#> + attr: name (g/c), type (g/c), loops (g/l), p (g/n)
#> + edges from dc0368b:
#>  [1]  1-- 3  1-- 5  3-- 8  7-- 8  5--11 10--11  2--12  3--14  5--14  1--15
#> [11] 10--15 11--15  4--16  6--16 12--16  1--17 15--17  3--18  4--18  8--19
#> [21] 11--19 12--19
x <- c(1, 3, 1, 5, 3, 8)
get_edge_ids(g, x)
#> [1] 1 2 3
m <- matrix(x, nrow = 2)
m
#>      [,1] [,2] [,3]
#> [1,]    1    1    3
#> [2,]    3    5    8
get_edge_ids(g, m)
#> [1] 1 2 3

^{Created on 2025-01-20 with reprex v2.1.1}

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[schochastics]

[.igraph is using the two-row matrix

rigraph/R/indexing.R

Line 186 in fe3b5b8

res <- get_edge_ids(x, rbind(from, to), error = FALSE)

The case of a 2x2 matrix will be tough to properly handle because we dont know if the user suplied edges row or column wise

[krlmlr]

Thanks!

[schochastics]

The warnings in tests are all from "wrong" use of get_edge_ids() with 2xn matrices. These occur all for [.igraph and [<-.igraph. So we need to merge #1658 and #1661 first and rebase this PR.

cc @maelle If you have time (no rush) can you check if my use of lifecycle (in code and tests) is ok? (never actively used it before)

hmm ok, I get warnings locally due to the deprecation of 2 x n matrices. Seems not to be checked here? cc @krlmlr

[krlmlr]

Thanks, can you please tweak and auto-merge when good?