Code cleanup and binary removal (#3793)

src/Makefile

@@ -34,8 +34,8 @@ LIBS := -pthread -lz
 CFLAGS_TP := $(CFLAGS)
 CXXFLAGS_TP := $(CXXFLAGS)
 
-# Add -Wconversion -Wsign-conversion -Weffc++ -Woverloaded-virtual flags back once we fix all other warnings!
-CFLAGS := $(CXXFLAGS) -Wall -Wextra -Wpedantic -Wfloat-conversion -Wshadow -Wfloat-equal -Wredundant-decls -Wdouble-promotion -Wunused -Wuninitialized -Wextra-semi
+# Add -Wconversion -Wsign-conversion -Weffc++ -Woverloaded-virtual -Wextra-semi flags back once we fix all other warnings!
+CFLAGS := $(CXXFLAGS) -Wall -Wextra -Wpedantic -Wfloat-conversion -Wshadow -Wfloat-equal -Wredundant-decls -Wdouble-promotion -Wunused -Wuninitialized
 
 ifdef FHEROES2_STRICT_COMPILATION
 CFLAGS := $(CFLAGS) -Werror

src/engine/system.cpp

@@ -211,23 +211,6 @@ const char * System::GetEnvironment( const char * name )
 #endif
 }
 
-int System::SetEnvironment( const char * name, const char * value )
-{
-#if defined( __MINGW32__ ) || defined( _MSC_VER )
-    std::string str( std::string( name ) + "=" + std::string( value ) );
-#if SDL_VERSION_ATLEAST( 2, 0, 0 )
-    return _putenv( str.c_str() );
-#else
-    // SDL 1.2.12 (char *)
-    return SDL_putenv( &str[0] );
-#endif
-#elif defined( __SWITCH__ ) || defined( FHEROES2_VITA )
-    return SDL_setenv( name, value, 1 );
-#else
-    return setenv( name, value, 1 );
-#endif
-}
-
 void System::SetLocale( int category, const char * locale )
 {
 #if defined( ANDROID ) || defined( __APPLE__ ) || defined( __clang__ )

src/engine/system.h

@@ -27,7 +27,6 @@
 
 namespace System
 {
-    int SetEnvironment( const char * name, const char * value );
     const char * GetEnvironment( const char * name );
 
     int MakeDirectory( const std::string & );

src/fheroes2/agg/bin_info.h

@@ -21,6 +21,7 @@
 #ifndef H2BIN_FRM_H
 #define H2BIN_FRM_H
 
+#include <cstddef>
 #include <vector>
 
 #include "math_base.h"