Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init solution for recipe_0033. #214

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

markpbaggett
Copy link
Member

@markpbaggett markpbaggett commented Dec 9, 2024

What Does This Do

This targets task 0033 here and adds a solution using Choice and the add_item helper. It might also serve as a solution for Issue-192 although maybe not as gracefully as what the user would like.

One note is that I could not get labels with auto configs to add directly to ResourceItems, so I created this_issue and was forced to use add_label. Assuming I didn't make a mistake, this is something we should look into.

@markpbaggett markpbaggett marked this pull request as draft December 9, 2024 15:07
@markpbaggett markpbaggett marked this pull request as ready for review December 9, 2024 15:54
@markpbaggett markpbaggett self-assigned this Dec 9, 2024
@glenrobson
Copy link
Contributor

Wait for fix for: #213

@glenrobson glenrobson linked an issue Dec 18, 2024 that may be closed by this pull request
@glenrobson glenrobson merged commit d536865 into iiif-prezi:main Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoLangConfig for Label Doesn't Seem to Work in this Case
2 participants