Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution for recipe_0046 and a helper to keep things neat. #222

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

markpbaggett
Copy link
Member

@markpbaggett markpbaggett commented Jan 6, 2025

What Does This Do

This adds a solution for recipe 0046 and a helper called add_rendering(). I added the helper so that one did not need to pass values as a list (i.e. rendering=[rendering]). The helper is attached to all classes in skeleton that has an optional rendering property and each of those classes are included in tests.

@markpbaggett markpbaggett changed the title Recipe 0046 Add solution for recipe_0046 and a helper to keep things neat. Jan 6, 2025
@markpbaggett markpbaggett marked this pull request as ready for review January 6, 2025 23:51
@glenrobson
Copy link
Contributor

Could this be done by using the auto list helper:

https://github.com/markpbaggett/iiif-prezi3/blob/e6810804a9f28ad643934bbdc2ea87d51b805ff2/iiif_prezi3/helpers/auto_fields.py#L153

If I remember correctly this will turn an item to a list if its not passed as a list

@markpbaggett
Copy link
Member Author

Could this be done by using the auto list helper:

https://github.com/markpbaggett/iiif-prezi3/blob/e6810804a9f28ad643934bbdc2ea87d51b805ff2/iiif_prezi3/helpers/auto_fields.py#L153

If I remember correctly this will turn an item to a list if its not passed as a list

@glenrobson, you are right. This is something I forgot (or maybe never knew). I rebased the change to the existing file and git rm the two unnecessary files that were introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants