move back to share_example usign describe block too

require fixed_values for all specs with as_json example

spec/support/shared_examples/json_format.rb

@@ -1,5 +1,8 @@
 shared_examples 'it has symmetric as_json and to_json methods' do
-  it 'should return a json representation of the object as a ruby hash' do
-    expect(subject.as_json).to eq JSON.parse(subject.to_json)
+  describe "#{described_class}.as_json" do
+    it 'should return a json representation of the object as a ruby hash' do
+      obj = described_class.new(fixed_values)
+      expect(obj.as_json).to eq JSON.parse(obj.to_json)
+    end
   end
 end

spec/unit/iiif/presentation/annotation_spec.rb

@@ -1,10 +1,10 @@
 describe IIIF::Presentation::Annotation do
 
+  let(:fixed_values) { {} }
+
   describe "#{described_class}.define_methods_for_abstract_resource_only_keys" do
     it_behaves_like 'it has the appropriate methods for abstract_resource_only_keys'
   end
 
-  describe "#{described_class}.as_json" do
-    it_behaves_like 'it has symmetric as_json and to_json methods'
-  end
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 end

spec/unit/iiif/presentation/canvas_spec.rb

@@ -42,13 +42,6 @@
     end
   end
 
-  describe '#as_json' do
-    # must have @id, width, height etc to pass validation in to_ordered_hash
-    # could also use to_oredered_hash(force: true) to skip validation
-    subject do
-      IIIF::Presentation::Canvas.new(fixed_values)
-    end
-    it_behaves_like 'it has symmetric as_json and to_json methods'
-  end
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 end
 

spec/unit/iiif/presentation/collection_spec.rb

@@ -49,9 +49,7 @@
   describe '#validate' do
   end
 
-  describe '#as_json' do
-    it_behaves_like 'it has symmetric as_json and to_json methods'
-  end
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 end
 
 

spec/unit/iiif/presentation/image_resource_spec.rb

@@ -19,14 +19,6 @@
       "width" => 750,
     }
   end
-
-  # describe '#as_json' do
-  #   # must have @id, width, height etc to pass validation in to_ordered_hash
-  #   # could also use to_oredered_hash(force: true) to skip validation
-  #   subject do
-  #     IIIF::Presentation::Canvas.new(fixed_values)
-  #   end
-  #   it_behaves_like 'it has symmetric as_json and to_json methods'
-  # end
+
   it_behaves_like 'it has symmetric as_json and to_json methods'
 end

spec/unit/iiif/presentation/layer_spec.rb

@@ -34,12 +34,7 @@
     it_behaves_like 'it has the appropriate methods for any-type keys'
   end
 
-  describe "#{described_class}.as_json" do
-    subject do
-      IIIF::Presentation::Layer.new(fixed_values)
-    end
-    it_behaves_like 'it has symmetric as_json and to_json methods'
-  end
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 
 end
 

spec/unit/iiif/presentation/manifest_spec.rb

@@ -11,9 +11,9 @@ def initialize(hsh={})
 
   let(:fixed_values) do
     {
-      'type' => 'a:SubClass',
-      'id' => 'http://example.com/prefix/manifest/123',
-      'context' => IIIF::Presentation::CONTEXT,
+      '@type' => 'a:SubClass',
+      '@id' => 'http://example.com/prefix/manifest/123',
+      '@context' => IIIF::Presentation::CONTEXT,
       'label' => 'Book 1',
       'description' => 'A longer description of this example book. It should give some real information.',
       'thumbnail' => {
@@ -86,4 +86,5 @@ def initialize(hsh={})
     it_behaves_like 'it has the appropriate methods for any-type keys'
   end
 
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 end

spec/unit/iiif/presentation/range_spec.rb

@@ -38,6 +38,7 @@
   describe '#validate' do
   end
 
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 end
 
 

spec/unit/iiif/presentation/resource_spec.rb

@@ -1,5 +1,13 @@
 describe IIIF::Presentation::Resource do
 
+  let(:fixed_values) do 
+    {
+      '@id' => 'http://www.example.org/iiif/book1/resource',
+      # '@type' => 'sc:Range',
+      'label' => 'Introduction'
+    }
+  end
+
   describe "#{described_class}.define_methods_for_abstract_resource_only_keys" do
     it_behaves_like 'it has the appropriate methods for abstract_resource_only_keys'
   end
@@ -12,5 +20,6 @@
     it_behaves_like 'it has the appropriate methods for string-only keys'
   end
 
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 end
 

spec/unit/iiif/presentation/sequence_spec.rb

@@ -105,6 +105,7 @@ def initialize(hsh={})
     end
   end
 
-
+  it_behaves_like 'it has symmetric as_json and to_json methods'
+
 end
 

spec/unit/iiif/service_spec.rb

@@ -1,4 +1,6 @@
 describe IIIF::Service do
+
+  let(:fixed_values) { {} }
 
   describe 'self#get_descendant_class_by_jld_type' do
     before do
@@ -25,8 +27,6 @@ def self.singleton_class?
     end
   end
 
-  describe '#as_json' do
-    it_behaves_like 'it has symmetric as_json and to_json methods'
-  end
+  it_behaves_like 'it has symmetric as_json and to_json methods'
 
 end