Better error handling #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpstroop
reviewed
Oct 19, 2016
| "format": "application/pdf", | ||
| "label": "Download as PDF" | ||
| }, | ||
| "seeAlso": [ |
There was a problem hiding this comment.
This is a bug in o'sullivan--a list should be allowed for seeAlso
jcoyne
requested changes
Oct 19, 2016
| def self.from_ordered_hash(hsh, default_klass=IIIF::OrderedHash) | ||
| unless hsh.is_a? Hash | ||
| raise IIIF::Service::ExpectedHashError, "expected a hash" |
There was a problem hiding this comment.
Why do we need a custom error here, wouldn't ArgumentError suffice?
| end | ||
| else | ||
| new_object[new_key] = hsh[key] | ||
| rescue ExpectedHashError |
There was a problem hiding this comment.
I'd prefer we don't do flow control with exceptions. Can we check that hsh[key] and member are hashes here?
|
This pull request has been replaced by #68 and may be closed. |
|
Closing this in favor of #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.