Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out nullish operator for ternary to allow loading in fastboot #49

Closed
wants to merge 1 commit into from
Closed

Conversation

jkeen
Copy link

@jkeen jkeen commented Aug 3, 2020

I love the nullish operator, but unfortunately fastboot errors upon startup with it in there. This PR switches it for the ternary operator.

P.S. Nice addon!

@ijlee2
Copy link
Owner

ijlee2 commented Aug 3, 2020

Thanks for the feedback! Yeah, the nullish coalescing operator bit me too in a production app that has FastBoot.

I discussed this issue with a few people on Discord, and I think the solution is for the end user of this addon to update their targets.js file.

Can you try the solution at ember-fastboot/ember-cli-fastboot#770 and let me know if that helps? Another reference is ember-fastboot/ember-cli-fastboot#764.

I think what I can do is to update the documentation to add a warning for FastBoot users. Would this be okay with you?

@jkeen
Copy link
Author

jkeen commented Aug 3, 2020

Ah ha! You're right. I tried googling for this and didn't find it, so yeah -- I think adding something to the readme would be very helpful.

@jkeen jkeen closed this Aug 3, 2020
@ijlee2
Copy link
Owner

ijlee2 commented Aug 3, 2020

Sounds good. I will work on updating the README tonight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants