Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore these mypy errors #1091

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Ignore these mypy errors #1091

merged 6 commits into from
Dec 13, 2024

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Dec 6, 2024

These errors are coming with the imminent update to latest inducer@main upstream pkgs. Tried, but didn't figure out how to get around them instance-by-instance.

https://github.com/illinois-ceesd/mirgecom/actions/runs/12190311488/job/34010485460?pr=926

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam marked this pull request as ready for review December 6, 2024 17:07
@MTCam MTCam requested a review from matthiasdiener December 6, 2024 17:07
@MTCam MTCam enabled auto-merge (squash) December 13, 2024 02:49
@MTCam MTCam merged commit d2eea03 into main Dec 13, 2024
13 checks passed
@MTCam MTCam deleted the ignore-some-mypy-errors branch December 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants