Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better MPI version logging #1092

Merged
merged 1 commit into from
Dec 11, 2024
Merged

better MPI version logging #1092

merged 1 commit into from
Dec 11, 2024

Conversation

matthiasdiener
Copy link
Member

  • only print version on rank 0
  • log library version

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

- only print version on rank 0
- log library version
@matthiasdiener matthiasdiener self-assigned this Dec 10, 2024
@matthiasdiener matthiasdiener requested a review from MTCam December 10, 2024 22:12
@matthiasdiener matthiasdiener enabled auto-merge (squash) December 10, 2024 23:41
@matthiasdiener matthiasdiener merged commit 450dce6 into main Dec 11, 2024
13 checks passed
@matthiasdiener matthiasdiener deleted the moar-mpi-ver branch December 11, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants