Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mengaldo BCs #805

Merged
merged 22 commits into from
Dec 12, 2022
Merged

Update Mengaldo BCs #805

merged 22 commits into from
Dec 12, 2022

Conversation

tulioricci
Copy link
Collaborator

Add no-shear stress condition for Symmetry/slip wall
Add RiemannInflow,
Add linearized Euler Eqs. for outflow
Rename OutflowBoundary to PressureOutflowBoundary

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci mentioned this pull request Dec 7, 2022
8 tasks
Removing excessive piece of code

Co-authored-by: Mike Campbell <[email protected]>
Comment on lines 1572 to 1577
self._ref_state = free_stream_state
self._mass = free_stream_density
self._velocity = free_stream_velocity
self._pressure = free_stream_pressure
self._temperature = free_stream_temperature
self._Y = free_stream_species_mass_fractions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's come this? Why not s'th like:

Suggested change
self._ref_state = free_stream_state
self._mass = free_stream_density
self._velocity = free_stream_velocity
self._pressure = free_stream_pressure
self._temperature = free_stream_temperature
self._Y = free_stream_species_mass_fractions
if free_stream_state is not None:
self._mass = free_stream_state.mass
(...) etc

... and then eliminate the if/else blocks that check for existence of self._ref_state?

@MTCam MTCam merged commit 63cbc32 into mengaldo-bcs Dec 12, 2022
@MTCam MTCam deleted the tulio/mengaldo-bcs branch December 12, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants