Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache folder #14

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Cache folder #14

merged 2 commits into from
Sep 26, 2019

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Aug 3, 2018

Ping @frauzufall.

Can you push your commits in this PR (you should be able to directly push in my branch hadim/cache-folder).

@ctrueden ctrueden added the to do label Oct 3, 2018
@frauzufall frauzufall self-assigned this Aug 7, 2019
@frauzufall
Copy link
Member

@hadim sorry for ignoring this for a year.. I added my changes and cleaned up the commits (I removed the pom-scijava update and the code style changes for now), After merging #18 I will force-push a rebased version to your branch here if you don't mind and then we can merge it.

@frauzufall
Copy link
Member

In case we are still fine with the system variable imagej.models.dir, I would merge this. I tested it by setting the variable in IntelliJ and behaved as expected.

@ctrueden
Copy link
Member

ctrueden commented Sep 4, 2019

We might want tensorflow in the property name somewhere, because other frameworks might need their own models directories. Or I suppose we could always take care in future for each library to double check that a given models directory matches its expectations?

@frauzufall
Copy link
Member

How about imagej.tensorflow.models.dir? In a future PR, we could also introduce imagej.tensorflow.downloads.dir to save the downloaded TF versions to.. And make these paths configurable in the Edit > Options > Tensorflow.. plugin....

hadim and others added 2 commits September 26, 2019 10:56
…ls.dir' to cache models

* during initModelCache the models are by default cached to Fiji.app/models
* now the property 'imagej.tensorflow.models.dir' can be used to set the directory where models are cached

Co-authored-by: Deborah Schmidt <[email protected]>
@frauzufall frauzufall merged commit 8fc5319 into imagej:master Sep 26, 2019
@frauzufall
Copy link
Member

I made a new issue for the related improvements I mentioned: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants