feat: better algorithm for custom tsconfig paths #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c4cd626 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@SukkaW Can I increase the limit to ? {
"name": "./lib/index.js",
"passed": false,
"size": 2855,
"sizeLimit": 2800
} |
This was referenced Feb 12, 2025
SukkaW
approved these changes
Feb 13, 2025
SukkaW
reviewed
Feb 13, 2025
Closed
|
@SukkaW Do you also want to add |
Yes, add one as well! |
|
@SukkaW Done! 🥳 |
SukkaW
approved these changes
Feb 14, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 14, 2025
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.7.0 | 3.8.0 | ## [v3.8.0](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#380) ##### Minor Changes - [#345](import-js/eslint-import-resolver-typescript#345) [`fcc8883`](import-js/eslint-import-resolver-typescript@fcc8883) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Enable the mapper function just for a set of allowed files. Improves project discovery using glob and POSIX separator. - [#346](import-js/eslint-import-resolver-typescript#346) [`c124e87`](import-js/eslint-import-resolver-typescript@c124e87) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update get-tsconfig to the the latest version. We now support the `${configDir}` variable, introduced in TypeScript 5.5.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 14, 2025
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.7.0 | 3.8.0 | ## [v3.8.0](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#380) ##### Minor Changes - [#345](import-js/eslint-import-resolver-typescript#345) [`fcc8883`](import-js/eslint-import-resolver-typescript@fcc8883) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Enable the mapper function just for a set of allowed files. Improves project discovery using glob and POSIX separator. - [#346](import-js/eslint-import-resolver-typescript#346) [`c124e87`](import-js/eslint-import-resolver-typescript@c124e87) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update get-tsconfig to the the latest version. We now support the `${configDir}` variable, introduced in TypeScript 5.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #246
Fix #247
Improves the overall algorithm for searching the mapped file when using custom TypeScript paths.
Each mapper now contains two fields:
mapperFnThe mapper function generated by
createPathsMatcherfilesA set of files where it is allowed to execute the
mapperFn.This resolves a number of issues, the most important of which is that two
tsconfigfiles have the same path mapping.One of the most important changes is to handle path separators appropriately:
tinyglobbypattern must have POSIX separator, otherwiseisDynamicPatternreturns false for some special cases (./packages/*/tsconfig.json)