Fix: prevent donation details page fatal error

[jonwaldstein]

Resolves: GIVE-2137

Description

This fixes a fatal error on the donation details page. The problem was our check for the campaign details page was returning true in cases it should not be. So it was adding a campaignId to the request that was not correct.

There was also some logic in the request itself that could have prevented a fatal error by conditionally checking params and model instances.

Affects

• The donations list table & details page.
• The donation forms list table within a campaign page (should only show related forms)

Visuals

Original problem this fixes:

donations-fatal-error.mov

Testing Instructions

• Create a campaign and donate using the campaign form
• Navigate to the donations list and click on edit donation
• You should not be presented with any fatal errors

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

[glaubersilva]

@jonwaldstein Looks good to me! No fatal errors were thrown in my tests.