Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Customize editor back button for Campaign Page post type #7714

Open
wants to merge 1 commit into
base: epic/campaigns
Choose a base branch
from

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Feb 7, 2025

Resolves GIVE-2142

Description

This PR customized the block editor back button to point to the edit URL of the Campaign related to the Campaign Page.

Visuals

Before After
Campaign Page list table Campaign Details page
Screenshot from 2025-02-07 11-34-58 Screenshot from 2025-02-07 11-34-29

Testing Instructions

From the Campaign Details page, click the "Edit campaign page" then navigate back to the Campaign Details page by clicking the back button (top left) in the editor.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson marked this pull request as ready for review February 7, 2025 16:49
@kjohnson kjohnson changed the title Feature: Customize editor back button for Campaign Page psot type Fix: Customize editor back button for Campaign Page psot type Feb 7, 2025
@kjohnson kjohnson changed the title Fix: Customize editor back button for Campaign Page psot type Fix: Customize editor back button for Campaign Page post type Feb 7, 2025
@jonwaldstein
Copy link
Contributor

@kjohnson nice job! I would just like to get @jdghinson's opinion of what icon we should put in that spot as I think this is a good time to make that decision. For reference:

Current PR has a close icon:

Screenshot 2025-02-07 at 2 44 37 PM

I do see in our donation form we have a link (to campaign overview)

Screenshot 2025-02-07 at 2 43 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants