Fix: Return 404 for campaign pages when disabled on the campaign #7716
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
Feb 7, 2025
|
|
||
| $campaignPage = CampaignPage::find(get_the_ID()); | ||
|
|
||
| if(!$campaignPage->campaign()->enableCampaignPage) { |
There was a problem hiding this comment.
To prevent a fatal error if $campaign is not found:
Suggested change
| if(!$campaignPage->campaign()->enableCampaignPage) { | |
| if($campaignPage && !$campaignPage->campaign()->enableCampaignPage) { |
Comment on lines
+27
to
+28
| get_template_part(404); | ||
| exit; |
There was a problem hiding this comment.
Suggested change
| get_template_part(404); | |
| exit; |
We can remove the exit statement so WP can still render a page, otherwise the website is unreachable.
vs
Also, it looks like we don't need the get_template_part either as WP must handle that up the chain via get_404_template()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2144
Description
This PR hooks into the page load to return a
404for a Campaign Page when the campaign page feature is disabled on the campaign.Testing Instructions
Create a Campaign and edit the Campaign Page. Then disable the campaign page feature and try to load the Campaign Page as a site visitor.
Pre-review Checklist
@unreleasedtags included in DocBlocks